Conversation
|
Comparing: d000261...b8b2373 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
josephsavona
reviewed
Nov 4, 2025
| // Component syntax version | ||
| // Should error because it's being passed down to JSX, although it's been referenced once | ||
| // in an effect | ||
| function MyComponent({ theme }) { |
Member
There was a problem hiding this comment.
this isn't using component syntax
josephsavona
approved these changes
Nov 4, 2025
Member
josephsavona
left a comment
There was a problem hiding this comment.
Ahh that would explain it! Looks good, just see one comment before landing
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 8, 2025
We were not recording uEE calls in component/hook syntax. Easy fix. Added tests matching function component syntax for component syntax + added one for hooks DiffTrain build for [8f8b336](facebook@8f8b336)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 8, 2025
We were not recording uEE calls in component/hook syntax. Easy fix. Added tests matching function component syntax for component syntax + added one for hooks DiffTrain build for [8f8b336](facebook@8f8b336)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not recording uEE calls in component/hook syntax. Easy fix.
Added tests matching function component syntax for component syntax + added one for hooks