Experiment: Taxonomies implement auto-fill labels#77786
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
48 tasks
|
Size Change: +675 B (+0.01%) Total Size: 7.82 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in f3b879c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25113498607
|
tyxla
reviewed
Apr 29, 2026
Member
tyxla
left a comment
There was a problem hiding this comment.
Nice work 👍
This works well in my testing, and code looks good.
I've made a few suggestions to address before merging it - let me know what you think!
22e5d34 to
f3b879c
Compare
| @@ -1,7 +1,13 @@ | |||
| @use "@wordpress/base-styles/colors" as *; | |||
Member
There was a problem hiding this comment.
We once again missed declaring "@wordpress/base-styles" as a dependency, and yes, I agree that it is very easy and bound to miss such things. 😄
These things should be solved automatically once we handle #76195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of: #77600
Adds two actions inside the taxonomy edit form's Labels card to make the labels section less manual:
All %s,Edit %s,← Back to %s,No %s found., etc.). Disabled until both Plural and Singular are set.The Labels card's previous prose description is consolidated into a single help paragraph rendered above the buttons, with an extra sentence reminding users to re-run Auto-fill after a rename.
Also: rows in the taxonomies list are now
isItemClickableand route to the edit page on click.How it's wired
The two buttons are rendered inside the Labels card via a small "phantom field" — a
Fieldwith no value (no-opgetValue/setValue) whose customEditrenders the help paragraph and the button row. It's the first child oflabelsForm.fieldsand useslabelPosition: 'none'so the regular layout suppresses the auto-rendered field label.This is a workaround for
DataFormcard layouts having no first-class slot for header actions or arbitrary React among children. The hack is annotated with a comment inpackages/user-taxonomies/src/fields/labels.tsxnoting that adding native per-card action support toDataFormwould let us drop it.Translation note (read this if you test locale switching)
The auto-fill localizes labels at click-time using
sprintf(__('All %s'), plural). This relies on the standard WP JS-translation pipeline (.potextraction → translate.wordpress.org → JSON language packs →wp_set_script_translations()). Localwp-envdoes not auto-load the JS catalog for newly-added strings, so switching the admin locale (e.g. to Greek) currently produces English prefixes alongside the translated noun (e.g. "All Σκυλιά"). That's expected pre-shipping behavior and will resolve once translations land in the package's catalog.Testing instructions
labelscard play around with theauto-fill/clearaction buttons.Use of AI Tools
Opus 4.7 with steering, changes and review