Conversation
Classic themes apply colors and focus/hover styles to button elements with high specificity, which leaks into the Tab block's toggle button. Mirror the Accordion Heading toggle approach so tabs inherit the surrounding colors and present a predictable focus outline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The reset styles for .wp-block-tab were adapted from the accordion heading toggle, and the inline comment still referenced "accordion toggle buttons". Update it to describe tab buttons so the rationale matches the selector. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +152 B (0%) Total Size: 7.78 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 6585d3f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24919254220
|
mirka
reviewed
Apr 24, 2026
Comment on lines
+66
to
+67
| background-color: inherit !important; | ||
| color: inherit !important; |
Member
There was a problem hiding this comment.
In a case with user-defined custom colors, do you know if we can be sure that the custom colors styles will always be loaded after classic.css? 😅 Looks a bit precarious at the moment, but maybe fine if the order is guaranteed.
(I'm not familiar with these block library features, so I might be missing things.)
Contributor
Author
There was a problem hiding this comment.
Nice catch! We can prioritize user-defined colors by checking for the CSS classes has-text-color or has-background.
Fixed in 6585d3f
Scope the inherit !important resets so they apply only when the tab does not carry has-text-color or has-background classes, allowing explicitly chosen colors to take effect under classic themes.
mirka
approved these changes
Apr 27, 2026
Member
mirka
left a comment
There was a problem hiding this comment.
Nice, let's go with that then 👍
6 tasks
t-hamano
added a commit
that referenced
this pull request
Apr 29, 2026
* Tabs: Add classic theme styles to reset button defaults Classic themes apply colors and focus/hover styles to button elements with high specificity, which leaks into the Tab block's toggle button. Mirror the Accordion Heading toggle approach so tabs inherit the surrounding colors and present a predictable focus outline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Tabs: Fix misleading comment copied from accordion styles The reset styles for .wp-block-tab were adapted from the accordion heading toggle, and the inline comment still referenced "accordion toggle buttons". Update it to describe tab buttons so the rationale matches the selector. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Tabs: Preserve user-defined colors against classic theme reset Scope the inherit !important resets so they apply only when the tab does not carry has-text-color or has-background classes, allowing explicitly chosen colors to take effect under classic themes. --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #73454
See: #75402 (comment)
What?
This PR provides a default tab button style for the classic theme.
Why?
Many classic themes apply styles to the button element. Due to the influence of these styles, active tabs may not be displayed correctly or may result in an unnatural design.
How?
To ensure that the default style is displayed appropriately in all themes, we will add minimal styles.
Testing Instructions
Enable any theme to check the tab styles.
Screenshots or screencast
Use of AI Tools
N/A