You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
x/telemetry/config: add dragon_slayer and move_declaration to gopls/interactive/command #82109
Following up on #79837, we are introducing two new interactive functionalities in gopls (introduced in v0.24.0 and to be released in v0.25.0):
dragon_slayer: A toy demonstration of interactive refactoring ("Slay the dragon") used to test and demonstrate interactive refactoring capabilities across LSP clients (CL 841525).
As established in #79837, the underlying interactivity occurs at the command level, and data collection is already handled generically in gopls/internal/server (CL 787200), which increments gopls/interactive/command:<commandName> when len(ExecuteCommandParam.FormAnswers) != 0.
Therefore, we only need to update the approved telemetry chart config to include these two new variants in the existing partition chart:
counter: gopls/interactive/command:{modify_tags,implement_interface,dragon_slayer,move_declaration}
title: Interactive Command Execution
description: use of interactive refactoring at command level
type: partition
issue: https://go.dev/issue/79837
issue: https://go.dev/issue/82109
program: golang.org/x/tools/gopls
module: golang.org/x/tools/gopls
version: v0.22.1
Summary
Following up on #79837, we are introducing two new interactive functionalities in gopls (introduced in v0.24.0 and to be released in v0.25.0):
dragon_slayer: A toy demonstration of interactive refactoring ("Slay the dragon") used to test and demonstrate interactive refactoring capabilities across LSP clients (CL 841525).move_declaration: Move declaration refactoring (x/tools/gopls: feature: "move declaration" refactoring #70583) which interactively prompts the user for target file and imports.As established in #79837, the underlying interactivity occurs at the command level, and data collection is already handled generically in
gopls/internal/server(CL 787200), which incrementsgopls/interactive/command:<commandName>whenlen(ExecuteCommandParam.FormAnswers) != 0.Therefore, we only need to update the approved telemetry chart config to include these two new variants in the existing partition chart:
cc @adonovan @madelinekalil
Proposed Config Change
CL 847668
Proposed Data Collection
Already implemented in CL 787200.