Core Data: Remove redundant memoization wrapper from 'getQueriedItems'#77483
Merged
Conversation
1 task
|
Size Change: -22 B (0%) Total Size: 7.82 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in b3b0e0e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25095171228
|
jsnajdr
approved these changes
Apr 29, 2026
Member
jsnajdr
left a comment
There was a problem hiding this comment.
Makes sense, if createSelector doesn't have a getDependants argument, the default is to use dependants in the form:
[ [ state, query, options ] ]i.e., one-member deps array where the single member is the array of arguments. Including state, different array on each call. That doesn't make much sense.
|
|
||
| ## Unreleased | ||
|
|
||
| ### Enhancements |
Member
There was a problem hiding this comment.
In packages where we really carefully maintain a changelog, like components or dataviews, this would be in the "Internal" section. "Enhancements" are usually user-visible new APIs and features.
Member
Author
There was a problem hiding this comment.
I was debating this myself. I'll change the section title.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Drop the `createSelector` (rememo) wrapper around `getQueriedItems`; keep the existing inner `EquivalentKeyMap`-based cache.
4c2518a to
b3b0e0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #76406 (comment).
Drop the
createSelector(rememo) wrapper aroundgetQueriedItems; keep the existing innerEquivalentKeyMap-based cache.Why?
Rememo caches by reference equality on arguments. Callers inline query objects (
getEntityRecords(state, 'postType', 'post', { per_page: 10 })), so the query is a new reference every call and rememo's cache never hits - every call fell through to the inner function.The inner
EquivalentKeyMapcaches by deep equality, which is how queries are actually passed. Removing the wrapper keeps behavior identical and drops per-call overhead (arg copy, WeakMap walk, linked-list scan).Testing Instructions
useSelecthook, which tests unstable references in dev mode.Testing Instructions for Keyboard
Same.