Link: Remove underline from unstyled icon links#77420
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.75 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8e5804a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24561162565
|
Member
|
I'm sure there were reasons, but the way we've implemented the component so that it has a different element structure applying the underline depending on Revisiting that implementation, I expect it was done the way it was to avoid the underline extending to the pseudo-element, and the screen reader reading pseudo-element content? Based on some light investigation and testing, maybe we can address that with a combination of |
Member
Author
|
@aduth Good idea, this is a lot cleaner. Confirmed working in Chrome/Safari/Firefox. |
ciampo
added a commit
that referenced
this pull request
Apr 21, 2026
* Fix unstyled link underline * Link: Simplify new tab icon rendering * Add changelog Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Prevent the
unstyledLinkvariant from showing an underline whenopenInNewTabis enabled.Why?
The previous
openInNewTabmarkup wrapped the label in a.link-contentsspan that re-applied underline styles. That was correct for default and neutral links, but it forced underline onto the label even when the root anchor wasunstyled, which should not apply link chrome.How?
openInNewTabcontent in.link-contentsand drop the.has-link-iconclass on the anchor. Children are always a fragment: link text, then the optional new-tab icon..link-iconasinline-blockandtext-decoration: noneso the underline stays on the text for styled variants, and the decorative arrow does not pick up decoration. Theunstyledvariant keepstext-decoration: noneon the anchor as before.toBeVisible, link accessible name includes the “opens in a new tab” phrase).Testing Instructions
Linkwithvariant="unstyled"andopenInNewTabset totrue.LinkwithopenInNewTabset totrue.Screenshots