CmdPal: Only list available docks when pinning#48723
Merged
Merged
Conversation
This is a totally minor nitpick. I don't have the dock enabled on all my displays. But the current "pin to dock" dialog lets me pin it to a display I don't have the dock on. When that happens, it effectively results in _nothing_ happening. Not great. This PR mitigates that situation, but only listing the enabled docks when pinning.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
michaeljolley
approved these changes
Jun 19, 2026
LegendaryBlair
pushed a commit
that referenced
this pull request
Jun 22, 2026
This is a totally minor nitpick. I don't have the dock enabled on all my displays. But the current "pin to dock" dialog lets me pin it to a display I don't have the dock on. When that happens, it effectively results in _nothing_ happening. Not great. This PR mitigates that situation, but only listing the enabled docks when pinning. (cherry picked from commit 6dcda8a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a totally minor nitpick.
I don't have the dock enabled on all my displays. But the current "pin to dock" dialog lets me pin it to a display I don't have the dock on. When that happens, it effectively results in nothing happening. Not great.
This PR mitigates that situation, but only listing the enabled docks when pinning.