Add text domain to translation target#499
Merged
Merged
Conversation
matiasbenedetto
left a comment
Contributor
There was a problem hiding this comment.
Hi! @Olein-jp, thanks for submitting this PR.
It seems like the translation domain for the string you updated is already there, and the PR is only changing whitespaces, or I'm missing something else?
| Plugin Description`, | ||
| 'create-block-theme' | ||
| ) } | ||
| value={ theme.recommended_plugins } |
Contributor
There was a problem hiding this comment.
It seems like the translation domain (create-block-theme) is already there.
Contributor
Author
There was a problem hiding this comment.
I added text domain here, but it gave me a JS syntax error, so I adjusted the whitespace separately.
Member
There was a problem hiding this comment.
Yeah, looks like the text domain was missing from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was using the plugin in a Japanese environment, I found a few points that were translated but not adapted.
After checking the source code, I found that the text domain was not described in the corresponding sections, so I added them.
I also found a few other cases, so we took the same measures.