close
Skip to content

"Convert a value to a key" should return invalid for detached array buffers#440

Merged
inexorabletash merged 4 commits intomainfrom
user/stevebe/update_keys_with_detached_array_buffers
Feb 26, 2025
Merged

"Convert a value to a key" should return invalid for detached array buffers#440
inexorabletash merged 4 commits intomainfrom
user/stevebe/update_keys_with_detached_array_buffers

Conversation

@SteveBeckerMSFT
Copy link
Copy Markdown
Collaborator

@SteveBeckerMSFT SteveBeckerMSFT commented Feb 26, 2025 •
edited by pr-preview Bot
Loading

Closes #417 by updating "7.4 Convert a value to a key" to return invalid when the input buffer source is detached.

The following tasks have been completed:

Implementation commitment:

Preview | Diff

@SteveBeckerMSFT SteveBeckerMSFT removed their assignment Feb 26, 2025
inexorabletash
inexorabletash requested changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things:

  • Add yourself to the Acknowledgements section
  • Add an entry to the Revision History section

Comment thread index.bs Outdated
<!-- Binary -->
: If |input| is a [=buffer source type=]
::
1. If [$IsDetachedBuffer$](|input|) is true then return invalid.
Copy link
Copy Markdown
Member

@inexorabletash inexorabletash Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsDetachedBuffer() takes an ArrayBuffer or a SharedArrayBuffer, but buffer source type includes the views. I think you'll need to dig the buffer out of the view in those cases?

Copy link
Copy Markdown
Collaborator Author

@SteveBeckerMSFT SteveBeckerMSFT Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I got the new steps from the WebIDL spec here:

https://webidl.spec.whatwg.org/#buffersource-detached

Copy link
Copy Markdown
Collaborator Author

@SteveBeckerMSFT SteveBeckerMSFT Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the latest revision to use the shorthand for these steps.

Copy link
Copy Markdown
Member

@inexorabletash inexorabletash Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. This all seemed very familiar... whatwg/webidl#1420 ... apparently we needed something similar over in WebNN. :)

@inexorabletash inexorabletash merged commit c659eb3 into main Feb 26, 2025
@inexorabletash
Copy link
Copy Markdown
Member

inexorabletash commented Feb 26, 2025

Thanks @SteveBeckerMSFT !

github-actions Bot added a commit that referenced this pull request Feb 26, 2025
@SteveBeckerMSFT @github-actions
"Convert a value to a key" should return invalid for detached array b…
cd62837 
…uffers (#440)

SHA: c659eb3
Reason: push, by inexorabletash

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stelar7 stelar7 mentioned this pull request Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inexorabletash inexorabletash inexorabletash approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistency between spec and tests for detached arraybuffers; spec for keys says don't throw, test for keys says throw, spec for values says throw

2 participants

@SteveBeckerMSFT @inexorabletash