[theme] Do not create channel tokens for custom colors when nativeColor is used#47765
Merged
ZeeshanTamboli merged 8 commits intomui:masterfrom Mar 30, 2026
Conversation
Netlify deploy previewhttps://deploy-preview-47765--material-ui.netlify.app/ Bundle size report
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
siriwatknp
reviewed
Feb 16, 2026
Member
Author
|
Could this be reviewed? |
Member
|
I have created mui/mui-x#21892, I think we can proceed with this PR. |
siriwatknp
reviewed
Mar 30, 2026
siriwatknp
reviewed
Mar 30, 2026
1 task
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
… of https://github.com/ZeeshanTamboli/material-ui into theme-do-not-throw-error-for-custom-colors-issue-47740
|
Cherry-pick PRs will be created targeting branches: v7.x |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
…lor` is used (#47765) Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com> Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves comment #47740 (comment).
We do not create the channel tokens when
nativeColoris used in theme. This is also mentioned in the docs: https://mui.com/material-ui/migration/upgrade-to-native-color/#remove-usage-of-channel-tokens.This also avoids throwing the warning mentioned in the comment.
Before: https://stackblitz.com/edit/nze14hel-zah7msat?file=src%2FDemo.tsx
After: https://stackblitz.com/edit/nze14hel-cqrupmyz?file=src%2FDemo.tsx