[ListItemIcon] Use theme spacing instead of hardcoded minWidth#46597
Merged
mj12albert merged 7 commits intomui:masterfrom Mar 30, 2026
Merged
[ListItemIcon] Use theme spacing instead of hardcoded minWidth#46597mj12albert merged 7 commits intomui:masterfrom
mj12albert merged 7 commits intomui:masterfrom
Conversation
… consistent icon spacing
Netlify deploy previewBundle size report
|
Contributor
Author
|
Hi! This PR fixes #46596 Thanks! |
Contributor
Author
|
Hi @ZeeshanTamboli review when you get a chance. Thanks! 🙏 |
Member
|
Thanks for submitting the PR. It's definitely better to me but it's a breaking change so I don't think this can be slot in v7. I'll keep this open. |
Member
|
@silviuaavram @siriwatknp I think it's not too late to include this tiny breaking change for v9 |
Member
Good one. |
siriwatknp
reviewed
Mar 30, 2026
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR replaces the hardcoded
minWidth: 56pxinListItemIconwiththeme.spacing(4.5)(36px), aligning spacing with other components likeMenuItem. This ensures consistent theming and avoids layout inconsistencies.This issue is visible in the MUI here:
👉 https://mui.com/material-ui/react-list/#nested-list
(Nested
ListItemIconshows inconsistent spacing due to hardcoded minWidth)Fixes
Closes #46596
Ensures icon spacing is responsive and theme-consistent.
Testing
List,Menu)Screenshots
🔴 Before
✅ After
Checklist