close
Skip to content

Support range formatting when using Black 23.11.0+.#380

Merged
karthiknadig merged 5 commits intomicrosoft:mainfrom
yilei:ranges
Dec 12, 2023
Merged

Support range formatting when using Black 23.11.0+.#380
karthiknadig merged 5 commits intomicrosoft:mainfrom
yilei:ranges

Conversation

@yilei
Copy link
Copy Markdown
Contributor

@yilei yilei commented Nov 17, 2023

Fixes #374

I wasn't able to write a test that can work, asking for help.

@karthiknadig karthiknadig self-assigned this Nov 17, 2023
@karthiknadig karthiknadig self-requested a review November 17, 2023 19:26
@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Nov 17, 2023
@karthiknadig
Copy link
Copy Markdown
Member

@yilei Thanks for the PR. I have modified your code a bit and added test. Please, accept CLA agreement, so we can merge this and you can get credits.

@yilei
Copy link
Copy Markdown
Contributor Author

yilei commented Nov 21, 2023

@microsoft-github-policy-service agree company="Google LLC"

@yilei
Copy link
Copy Markdown
Contributor Author

yilei commented Nov 21, 2023

@karthiknadig Thanks for the changes, CLA accepted.

@pktiuk
Copy link
Copy Markdown

pktiuk commented Dec 4, 2023

@karthiknadig
When can we expect merging this PR?

@karthiknadig
Copy link
Copy Markdown
Member

@pktiuk I just addressed the merge conflicts in the PR. It should get merged soon.

@karthiknadig karthiknadig merged commit 608c698 into microsoft:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "Format Selection" now that Black 23.11.0 adds a --line-ranges= CLI option.

5 participants