close
Skip to content

[Build] Reduce amount of warnings#1944

Merged
DaveDavenport merged 1 commit intodavatorium:nextfrom
lbonn:less-warnings
Feb 16, 2024
Merged

[Build] Reduce amount of warnings#1944
DaveDavenport merged 1 commit intodavatorium:nextfrom
lbonn:less-warnings

Conversation

@lbonn
Copy link
Copy Markdown
Collaborator

@lbonn lbonn commented Feb 16, 2024

Remove some warnings which pop up when building rofi and hide real issues when developing

  • one unused parameter in recursivebrowser.c
  • overlength strings are overly pedantic, modern compilers support large strings
  • __FUNCTION__ creeped back in after warning: ISO C does not support #288

What's left:

  • non conformant cast in libgwater
../subprojects/libgwater/xcb/libgwater-xcb.c:160:35: warning: ISO C forbids conversion of object pointer to function pointer type [-Wpedantic]
  160 |     g_source_set_callback(source, (GSourceFunc)(void *)callback, user_data, destroy_func);
  • unchecked return values (always write(), dmenu.c and recursivebrowser.c)
../source/modes/dmenu.c:309:19: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  309 |                   write(pd->pipefd2[1], "r", 1);

* one unused parameter in recursivebrowser.c
* overlength strings are overly pedantic, modern compilers support large
  strings
* __FUNCTION__ creeped back in after davatorium#288
@DaveDavenport DaveDavenport merged commit f539a08 into davatorium:next Feb 16, 2024
@lbonn lbonn deleted the less-warnings branch February 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants