challenge(formatter): noInitializerWithDefinite rule#802
Merged
ematipico merged 5 commits intobiomejs:mainfrom Nov 20, 2023
Merged
challenge(formatter): noInitializerWithDefinite rule#802ematipico merged 5 commits intobiomejs:mainfrom
noInitializerWithDefinite rule#802ematipico merged 5 commits intobiomejs:mainfrom
Conversation
Contributor
|
I guess you may need to run |
unvalley
reviewed
Nov 20, 2023
Co-authored-by: unvalley <38400669+unvalley@users.noreply.github.com>
Conaclos
reviewed
Nov 20, 2023
Member
Conaclos
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I left one comment.
Co-authored-by: Victorien Elvinger <victorien@elvinger.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR removes the bogus marking of TypeScript variable definitions with definite assertions that are initialized and instead moves it to a new lint rule
noInitializerWithDefinite.(https://discord.com/channels/1132231889290285117/1132602615570649110/1175767286968242266)
Test Plan
I added some test cases on
biome_js_analyzeand also have 100% Prettier Similarity fortypescript/definite/definite.