challenge(formatter): Attach comments to labels#730
Merged
Conversation
Contributor
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
730c909 to
d35c1a5
Compare
d35c1a5 to
1de9074
Compare
1de9074 to
76023c1
Compare
Member
|
It's a bit unfortunate that we need to add a new node. But I suppose it's fine! |
ematipico
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This partially fixes js/comments/break-continue-statements.js.
Prettier has a dedicated syntax node for labels. This allows attaching comments to the label. Biome has n osuch node and thus moves comments at the end of the statement.
To fix the difference, I introduced a new CST node
JsLabel.The node have to be introduced for
JsBreakStatementandJsContinueSTatement. For uniformity, I also usedJsLabelforJsLabeledSatteement. Alternatively, we could still directly use a token forJsLabeledSatteementor differentiateJsLabelintoJsLabelReferenceandJsLabelBinding. Any opinion?For now, leading comments are correctly attached to the label.
I encounter an issue with trailing comments: when I changed the code to attach them to the label I got a reformat instability.
Test Plan
Updated.