Bring select inputs in line with text inputs on checkout#63608
Conversation
Testing GuidelinesHi @senadir , Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a changelog entry documenting a fix to make the select component's focused state consistent with other input types by updating the dark-controls focus styling from border-color-only to explicit color and border properties. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.4.0)plugins/woocommerce/client/blocks/assets/js/base/components/select/style.scssConfigurationError: Could not find "@wordpress/stylelint-config/scss". Do you need to install the package or use the "configBasedir" option? Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: +8 B (0%) Total Size: 5.98 MB |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |

Changes proposed in this Pull Request:
In dark mode, when inputs are focused, they get a color of #fff and the border matches it. Select inputs are inconsistent and do not get this, so tabbing through a form results in inconsistencies.
(For Bug Fixes) Bug introduced in PR # .
Screenshots or screen recordings:
In both screenshots, the select input is focused.
For reference, this is a focused text input
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Dark mode inputsTesting that has already taken place:
Milestone
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment