close
Skip to content

Docs: Add missing type="button" to Cheatsheet nav buttons - #39585

Merged
julien-deramond merged 2 commits into
twbs:mainfrom
coliff:dev/coliff/cheatsheet-button-fix
Jan 30, 2024
Merged

julien-deramond merged 2 commits into
twbs:mainfrom
coliff:dev/coliff/cheatsheet-button-fix

Conversation

@coliff

@coliff coliff commented Jan 15, 2024 •

Copy link
Copy Markdown
Contributor

Description

Fix a very minor issue (reported by Webhint):
https://webhint.io/docs/user-guide/hints/hint-button-type/

Motivation & Context

The default type for is submit (not type="button" as one might expect). This can lead to surprising keyboard behavior within a form. We added type="button" to all other buttons on the site - makes sense to add them here too.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff coliff changed the title Add missing type="button" to Cheatsheet nav buttons Docs: Add missing type="button" to Cheatsheet nav buttons Jan 15, 2024
@julien-deramond julien-deramond added examples The examples in the docs v5 v5, the v5-dev branch labels Jan 30, 2024
@julien-deramond
julien-deramond merged commit 0476078 into twbs:main Jan 30, 2024
@coliff
coliff deleted the dev/coliff/cheatsheet-button-fix branch January 30, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples The examples in the docs v5 v5, the v5-dev branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants