close
The Wayback Machine - https://web.archive.org/web/20250325124502/https://github.com/python/cpython/pull/19027
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39879: update language reference to specify that dict is insertion-ordered. #19027

Closed
wants to merge 4 commits into from
Closed

bpo-39879: update language reference to specify that dict is insertion-ordered. #19027

wants to merge 4 commits into from

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Mar 16, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 16, 2020
isidentical
isidentical reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@furkanonder furkanonder requested a review from isidentical March 16, 2020 09:51
@furkanonder @isidentical
Update Doc/reference/datamodel.rst
e48cc00 
Co-Authored-By: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
zware
zware requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also my comment on the issue.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@furkanonder furkanonder requested a review from zware March 17, 2020 23:17
@furkanonder
Copy link
Contributor Author

It was combined with another pr. => #19006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakancelikdev hakancelikdev hakancelikdev approved these changes

@isidentical isidentical Awaiting requested review from isidentical

@zware zware Awaiting requested review from zware

Assignees
No one assigned
Labels
awaiting changes docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@furkanonder @bedevere-bot @zware @hakancelikdev @isidentical @the-knights-who-say-ni