Further optimize distribution() searching.#272
Merged
Conversation
Member
|
Thanks for this. It's excellent. The only real wish I have (for future consideration) is if these optimizations had been committed and pushed separately, we could see the impact of each change independently. Any idea why the Python 3.6 tests are timing out? |
Member
Oh, dear. I see the Python 3.6 tests have been timing out for some time, although apparently only intermittently. I'll bet it's some bug with pips resolver and selective dependencies on self (importlib_metadata). I'll deal with that in another issue/pr. |
As a consequence, `ext` doesn't include the leading dot anymore, so change `suffixes` accordingly too.
Contributor
Author
Done. |
Member
|
Looks like the second and third commits had the most impact: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Locally, this speeds up
distribution("ipython")on a large-ishenvironment by nearly 2-fold. (The GHA benchmark goes from ~1.6ms
to ~0.8ms.)
All the following changes matter for the performance gain:
(See https://gitlab.com/python-devs/importlib_metadata/-/issues/95 for
rationale why performance matters.)