close
The Wayback Machine - https://web.archive.org/web/20200407071406/https://github.com/twitter/twurl/pull/138
Skip to content

/ twurl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode remote container setting files #138

Merged
merged 3 commits into from Dec 30, 2019
Merged

Add VSCode remote container setting files #138

merged 3 commits into from Dec 30, 2019

Conversation

@smaeda-ks
Copy link
Collaborator

smaeda-ks commented Dec 30, 2019 •
edited

https://code.visualstudio.com/docs/remote/containers
What does this mean? so developers who installed VSCode + Docker can start twurl development instantly without setting up Ruby environment on their own machines.

Also, removing rubyforge_project options from .gemspec as it's deprecated.
smaeda-ks added 3 commits Dec 30, 2019
@smaeda-ks
rubyforge_project option is deprecated
c69fcf4
@smaeda-ks
Adding Dockerfile for VSCode remote development
989f75f
@smaeda-ks
simplify .gemspec
Loading status checks…
759c0df
@smaeda-ks smaeda-ks added the Trivial label Dec 30, 2019
@smaeda-ks smaeda-ks requested a review from twitter/twurl-admins Dec 30, 2019
@smaeda-ks smaeda-ks self-assigned this Dec 30, 2019
@coveralls

This comment has been minimized.

Sign in to view
Copy link

coveralls commented Dec 30, 2019 •
edited

Coverage Status

Coverage increased (+0.01%) to 88.565% when pulling 759c0df on smaeda-ks:smaeda-ks/docker-vscode into 4e8b5f9 on twitter:master.
@andypiper
andypiper approved these changes Dec 30, 2019
View changes
Copy link
Member

andypiper left a comment

Looks good, ok to merge.
@smaeda-ks smaeda-ks merged commit 23a8374 into twitter:master Dec 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypiper andypiper

Assignees

@smaeda-ks smaeda-ks

Labels
Trivial
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@smaeda-ks @coveralls @andypiper
You can’t perform that action at this time.