Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate: Return the color value on useColors #18544
Merged
Conversation
jorgefilipecosta
requested review from
ellatrix,
talldan and
youknowriad
as
code owners
jorgefilipecosta
force-pushed the
update/pass-the-color-value-on-use-colors
branch
from
fcf58c9
to
6dcce9c
|
Tested with the heading component and found no issues because of the change. Also tested as part of #18540 where the change was used for a toolbar control and worked great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jorgefilipecosta commentedNov 15, 2019
Description
The useColors hook does not provide a way to access the color value.
If we want to create a slightly different color UI like the navigation block needs we need to access the color value.
Themes set the color property as the color value, and slug as the named color value, previously withColor also did that. Currently, useColors returns color as the named color.
This PR changes useColors to also return a color property in the color components, and returns the color slug in the slug property.
How has this been tested?
I verified the color on the heading block works as expected.
I used the debugger and verified the color and slug property contain the expected values for the three different cases: no color selected, custom color selected, preset color selected.