Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix content loss in Group block #1209
Conversation
Tug
added
the
bugfix
label
Jul 9, 2019
Tug
added this to the 1.9 milestone
Jul 9, 2019
Tug
requested a review
from hypest
Jul 9, 2019
Tug
self-assigned this
Jul 9, 2019
Tug
added some commits
Jul 9, 2019
hypest
approved these changes
Jul 9, 2019
|
LGTM! Small note, main WP apps cannot be used directly against this PR since there are some bridge changes (merged in a different PR) that haven't yet been adapted. I manually made the adaptation and verified this PR works OK! Also, good job helping out on the Gutenberg side PR that @mcsf started! Feel free to update this PR and merge when the Gutenberg side PR gets merged |
Tug
merged commit 44e263c
into
develop
Jul 9, 2019
1 of 6 checks passed
ci/circleci: Check Correctness
Your tests are queued behind your running builds
Details
ci/circleci: Test Android
Your tests are queued behind your running builds
Details
ci/circleci: Test Android on Device
Your tests are queued behind your running builds
Details
ci/circleci: Test iOS
Your tests are queued behind your running builds
Details
ci/circleci: Test iOS on Device
CircleCI is running your tests
Details
Peril
All green. Well done.
Details
Tug
deleted the
try/fix-parser-reserialize-unknown-blocks
branch
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.



Tug commentedJul 9, 2019
•
edited by hypest
Fixes #1206
Gutenberg side PR: WordPress/gutenberg#14443
To test:
initial-html.jsUpdate release notes: