Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue/update color scheme #10283
+1,697
−1,735
Conversation
theck13
added some commits
Jul 23, 2019
theck13
added some commits
Jul 23, 2019
theck13
added this to the 13.0 milestone
Jul 25, 2019
theck13
requested review from
khaykov,
planarvoid and
mattmiklic
Jul 25, 2019
This comment has been minimized.
This comment has been minimized.
|
This is looking good to me; I did a side-by-side comparison of screens in this alpha build with the same screens on iOS. The only thing I noticed was the use of WordPress blue instead of the regular blue for some links and icons, which we've already talked about and we'll address later. |
mattmiklic
removed their request for review
Jul 26, 2019
wordpress-mobile
deleted a comment from
peril-wordpress-mobile bot
Jul 26, 2019
khaykov
self-assigned this
Jul 26, 2019
wordpress-mobile
deleted a comment from
peril-wordpress-mobile bot
Jul 26, 2019
wordpress-mobile
deleted a comment from
peril-wordpress-mobile bot
Jul 27, 2019
khaykov
merged commit 2f028c0
into
develop
Jul 28, 2019
khaykov
deleted the
issue/update-color-scheme
branch
Jul 28, 2019
wordpress-mobile
deleted a comment from
peril-wordpress-mobile bot
Jul 28, 2019
wordpress-mobile
deleted a comment from
peril-wordpress-mobile bot
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
theck13 commentedJul 25, 2019
Fix
Update the color scheme to Color Studio v2.0.0 to close #10165. These changes include updating color values, refactoring color names, renaming file names based on the new color values/names, and removing unused colors. There are no functional changes.
Test
An alpha build can be downloaded from here. It will be installed alongside the production build (i.e. two WordPress apps will be on the device; one production and one debug) so changes can be compared on the same device.
Review
Only one developer is required to review these changes, but anyone can perform the review. The code review should not worry about the color names or specific changes to the color of the interface, but it should check that there are no breaking changes. The design and interface will be reviewed by @mattmiklic.