close
The Wayback Machine - https://web.archive.org/web/20200909175426/https://github.com/tj/co/pull/225
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish co-browser.js to npm #225

Merged
merged 1 commit into from Sep 11, 2015
Merged

publish co-browser.js to npm #225

merged 1 commit into from Sep 11, 2015

Conversation

@lambdabaa
Copy link
Contributor

lambdabaa commented May 25, 2015

When a repository lacks an .npmignore file, npm will fall back on .gitignore. Currently co's .gitignore specifies co-browser.js which is keeping it from being published to the npm even though it's generated in the prepublish npm step.

@jonathanong Looks good?

@jonathanong
Copy link
Contributor

jonathanong commented May 26, 2015

no, you should just be adding it to the .files array in the package.json instead :)

gaye
@lambdabaa
Copy link
Contributor Author

lambdabaa commented May 26, 2015

Done

@lambdabaa
Copy link
Contributor Author

lambdabaa commented May 28, 2015

@jonathanong Can we land this?

@lambdabaa
Copy link
Contributor Author

lambdabaa commented Jun 11, 2015

@tj ? It's been two weeks and this is a one line manifest change to get a browser build into the npm package. Curiously ab5815f seems to think it solved this issue...

@fengmk2
Copy link
Collaborator

fengmk2 commented Sep 9, 2015

+1

@fengmk2
Copy link
Collaborator

fengmk2 commented Sep 11, 2015

Wait for a moment, @gaye if using browserify, why do you need this file?

@lambdabaa
Copy link
Contributor Author

lambdabaa commented Sep 11, 2015

It's good to have around for non-browserify, browser consumers

@fengmk2
Copy link
Collaborator

fengmk2 commented Sep 11, 2015

Sound good.

fengmk2 added a commit that referenced this pull request Sep 11, 2015
publish co-browser.js to npm
@fengmk2 fengmk2 merged commit e679907 into tj:master Sep 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@fengmk2
Copy link
Collaborator

fengmk2 commented Sep 11, 2015

@jonathanong Publish a new patch version to npm? Or add me to the npm owner list too?

@webuniverseio
Copy link

webuniverseio commented Oct 5, 2015

I don't see co-browser in npm for 4.6.0. Does that mean that files array doesn't work?

@nathanboktae
Copy link

nathanboktae commented Dec 16, 2015

This fix came in after 4.6.0 @szarouski . Can we get a 4.6.1 / 4.7.0 with this available please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.