Adding a global Env to the extension API #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * The version of the editor. | ||
| */ | ||
| export var version: string; |
There was a problem hiding this comment.
that is API breakage which we cannot do
|
Addressed feedback, merging. |
sofianhn
pushed a commit
that referenced
this pull request
Jan 21, 2016
Adding a global Env to the extension API
| this.env = { | ||
| machineId: info.machineId, | ||
| sessionId: info.sessionId, | ||
| locale: null |
There was a problem hiding this comment.
this is not good. either fill in or don't have it yet - i'll tackle
|
@sofianhn you can get to the locale in the redener using: window.navigator.language |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a global Env variable that can contain information about VSCode.
The Evn variable for now contains: