Pods 3.3.10 - #7553
Open
PodsBot wants to merge 11 commits into
Open
Conversation
sc0ttkclark
force-pushed
the
release/3.3.10
branch
from
June 8, 2026 02:56
19e8b2e to
e42f8d4
Compare
…d in some circumstances Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
sc0ttkclark
force-pushed
the
release/3.3.10
branch
from
June 8, 2026 04:04
c1e5cae to
9dcdebc
Compare
sc0ttkclark
marked this pull request as ready for review
July 23, 2026 15:03
There was a problem hiding this comment.
Pull request overview
Release-prep changes for the Pods 3.3.10 pre-release, including a fix to Whatsit::count_groups() and associated version/dependency/workflow updates.
Changes:
- Fix
Whatsit::count_groups()to reliably return an integer when cached groups are present. - Bump plugin/package versions and update changelog for 3.3.10.
- Refresh dev dependencies and GitHub Actions workflow action versions.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Pods/Whatsit.php |
Fixes count_groups() cached-return behavior to match its int contract. |
readme.txt |
Updates stable tag and adds a 3.3.10 changelog entry. |
package.json |
Bumps package version to 3.3.10-a-1. |
init.php |
Bumps plugin header version and PODS_VERSION constant to 3.3.10-a-1. |
composer.json |
Updates dev dependencies and adds the wp-packages Composer repository. |
.github/workflows/tests-php.yml |
Updates workflow action versions used by the PHP test pipeline. |
Files not reviewed (1)
- src/Pods/Whatsit.php: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
71
to
73
| "stellarwp/coding-standards": "dev-main", | ||
| "symfony/console": "^7.4", | ||
| "szepeviktor/phpstan-wordpress": "^v1.3", |
|
|
||
| == Changelog == | ||
|
|
||
| = 3.3.10 - June 8th, 2026 = |
Comment on lines
1388
to
1391
|
|
||
| if ( null !== $this->_groups && ! $has_custom_args ) { | ||
| return $this->_groups; | ||
| return count( $this->_groups ); | ||
| } |
Refactor is_empty method to use pods_trim and improve empty value checks. Resolves issues with PHP trim() issues with non-strings. Also supporting multiple date values in is_empty(). Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
This fixes issues with PHP string juggling on functions that can't take nulls. Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action