close
The Wayback Machine - https://web.archive.org/web/20210825043643/https://github.com/atom/github/pull/2413
Skip to content

/ github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes failing tests on electron 5 #2413

Merged
merged 4 commits into from Feb 26, 2020
Merged

Fixes failing tests on electron 5 #2413

merged 4 commits into from Feb 26, 2020

Conversation

@darangi
Copy link
Member

@darangi darangi commented Feb 26, 2020 •
edited

Fixes

atom/atom#20411

Description of the Change

This fix failing tests when the GitHub package tests are executed against electron 5. These failing tests make the CI exit without proper errors.
darangi added 3 commits Feb 26, 2020
@darangi
force the dom to update
eb4e0a3
@darangi
set nodeintegration to true in browserWindow
8d1c8d1
@darangi
commented branch test
4b82388
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020 •
edited

Codecov Report

Merging #2413 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
- Coverage   93.52%   93.38%   -0.15%     
==========================================
  Files         235      235              
  Lines       13147    13147              
  Branches     1885     1885              
==========================================
- Hits        12296    12277      -19     
- Misses        851      870      +19
Impacted Files Coverage Δ
lib/worker-manager.js 90.79% <100%> (ø) ⬆️
lib/models/branch.js 84.21% <0%> (-14.74%) ⬇️
lib/git-temp-dir.js 96.77% <0%> (-3.23%) ⬇️
lib/git-prompt-server.js 97.29% <0%> (-2.71%) ⬇️
lib/helpers.js 89.3% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ecbdc...ca6774b. Read the comment docs.

@darangi
fixed lint problems
ca6774b
@darangi darangi marked this pull request as ready for review Feb 26, 2020
@darangi darangi requested a review from lkashef Feb 26, 2020
darangi added a commit that referenced this issue Feb 26, 2020
@darangi
Merge pull request #2413 from atom/add-electron5-support
0fcd3cc 
Fixes failing tests on electron 5
@darangi darangi merged commit 0fcd3cc into master Feb 26, 2020
8 checks passed
8 checks passed
@azure-pipelines[bot]
atom.github Build #20200226.2 succeeded
Details
@azure-pipelines[bot]
atom.github (Lint) Lint succeeded
Details
@azure-pipelines[bot]
atom.github (Linux) Linux succeeded
Details
@azure-pipelines[bot]
atom.github (MacOS) MacOS succeeded
Details
@azure-pipelines[bot]
atom.github (Snapshot) Snapshot succeeded
Details
@azure-pipelines[bot]
atom.github (Windows) Windows succeeded
Details
@codecov[bot]
codecov/patch 100% of diff hit (target 93.52%)
Details
@codecov[bot]
codecov/project Absolute coverage decreased by -0.14% but relative coverage increased by +6.47% compared to 29ecbdc
Details
@darangi darangi deleted the add-electron5-support branch Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkashef lkashef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@darangi