Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNormalize comment path #2305
Merged
Normalize comment path #2305
Conversation
|
Updating this existing beforeEach build is enough to fail pre-patch code (only on windows, which is the only place the bug exists too), however when it fails they will see a stack trace that looks identical to #2302. So, I have not technically created a test case, but can if you want. |
|
Works for me. Thanks! |
| @@ -235,7 +235,7 @@ describe('ReviewsView', function() { | |||
| .addReviewThread(t => { | |||
| t.thread(t0 => t0.id('abcd')); | |||
| t.addComment(c => | |||
| c.id(0).path('dir/file0').position(10).bodyHTML('i have opinions.').author(a => a.login('user0').avatarUrl('user0.jpg')), | |||
| c.id(0).path('dir/file0').position(10).bodyHTML('i have a bad windows file path.').author(a => a.login('user0').avatarUrl('user0.jpg')), | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wadethestealth commentedOct 11, 2019
•
edited
This fixes #2302, where loading review comments was causing an error because the comment path and translation path were using opposite slashes for the file path.
Fixes #2302